summaryrefslogtreecommitdiffstats
path: root/drivers/ptp
diff options
context:
space:
mode:
authorDmitry Torokhov <dmitry.torokhov@gmail.com>2017-02-14 10:23:32 -0800
committerDavid S. Miller <davem@davemloft.net>2017-02-17 11:03:06 -0500
commit6f7aa56bae6ff38727d5c8bf6ee7d4202b4e3865 (patch)
tree14f800474cdfab3fa80eedb0462d84a52e82b08c /drivers/ptp
parent882f312dc0751c973db26478f07f082c584d16aa (diff)
downloadlinux-6f7aa56bae6ff38727d5c8bf6ee7d4202b4e3865.tar.gz
linux-6f7aa56bae6ff38727d5c8bf6ee7d4202b4e3865.tar.bz2
linux-6f7aa56bae6ff38727d5c8bf6ee7d4202b4e3865.zip
ptp: use kcalloc when allocating arrays
kcalloc is more semantically correct when allocating arrays of objects, and overflow-safe. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ptp')
-rw-r--r--drivers/ptp/ptp_sysfs.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c
index 53d43954a974..27cd46ab5e32 100644
--- a/drivers/ptp/ptp_sysfs.c
+++ b/drivers/ptp/ptp_sysfs.c
@@ -269,13 +269,12 @@ static int ptp_populate_pins(struct ptp_clock *ptp)
struct ptp_clock_info *info = ptp->info;
int err = -ENOMEM, i, n_pins = info->n_pins;
- ptp->pin_dev_attr = kzalloc(n_pins * sizeof(*ptp->pin_dev_attr),
+ ptp->pin_dev_attr = kcalloc(n_pins, sizeof(*ptp->pin_dev_attr),
GFP_KERNEL);
if (!ptp->pin_dev_attr)
goto no_dev_attr;
- ptp->pin_attr = kzalloc((1 + n_pins) * sizeof(struct attribute *),
- GFP_KERNEL);
+ ptp->pin_attr = kcalloc(1 + n_pins, sizeof(*ptp->pin_attr), GFP_KERNEL);
if (!ptp->pin_attr)
goto no_pin_attr;