diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2023-09-22 17:40:44 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-10-02 07:19:22 +0100 |
| commit | caa0578c1d487d39e4bb947a1b4965417053b409 (patch) | |
| tree | 9e3494ae886cc677501f234f4ea57305781ed81b /drivers/ptp | |
| parent | c889a99a21bf124c3db08d09df919f0eccc5ea4c (diff) | |
| download | linux-caa0578c1d487d39e4bb947a1b4965417053b409.tar.gz linux-caa0578c1d487d39e4bb947a1b4965417053b409.tar.bz2 linux-caa0578c1d487d39e4bb947a1b4965417053b409.zip | |
ptp: ocp: Fix error handling in ptp_ocp_device_init
When device_add() fails, ptp_ocp_dev_release() will be called
after put_device(). Therefore, it seems that the
ptp_ocp_dev_release() before put_device() is redundant.
Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Vadim Feodrenko <vadim.fedorenko@linux.dev>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ptp')
| -rw-r--r-- | drivers/ptp/ptp_ocp.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 20a974ced8d6..a7a6947ab4bc 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -3998,7 +3998,6 @@ ptp_ocp_device_init(struct ptp_ocp *bp, struct pci_dev *pdev) return 0; out: - ptp_ocp_dev_release(&bp->dev); put_device(&bp->dev); return err; } |