summaryrefslogtreecommitdiffstats
path: root/drivers/regulator/qcom_spmi-regulator.c
diff options
context:
space:
mode:
authorStephen Boyd <sboyd@codeaurora.org>2016-04-15 10:44:37 -0700
committerMark Brown <broonie@kernel.org>2016-04-18 11:05:11 +0100
commitb1d21a24df458c897911af51cb637460c1ac5d95 (patch)
tree0e76986a75be135035c79913483dbc5aa316dd58 /drivers/regulator/qcom_spmi-regulator.c
parent1b5b19689278069844f0f65bba8ea55facad90f9 (diff)
downloadlinux-b1d21a24df458c897911af51cb637460c1ac5d95.tar.gz
linux-b1d21a24df458c897911af51cb637460c1ac5d95.tar.bz2
linux-b1d21a24df458c897911af51cb637460c1ac5d95.zip
regulator: qcom_spmi: Always return a selector when asked
I had a thinko in spmi_regulator_select_voltage_same_range() when converting it to return selectors via the function's return value instead of by modifying a pointer argument. I only tested multi-range regulators so this passed through testing. Fix it by returning the selector here. Fixes: 1b5b19689278 ("regulator: qcom_spmi: Only use selector based regulator ops") Reported-by: Rajendra Nayak <rnayak@codeaurora.org> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator/qcom_spmi-regulator.c')
-rw-r--r--drivers/regulator/qcom_spmi-regulator.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
index f502f2cc65d8..84cce21e98cd 100644
--- a/drivers/regulator/qcom_spmi-regulator.c
+++ b/drivers/regulator/qcom_spmi-regulator.c
@@ -692,7 +692,7 @@ static int spmi_regulator_select_voltage_same_range(struct spmi_regulator *vreg,
if (selector >= vreg->set_points->n_voltages)
goto different_range;
- return 0;
+ return selector;
different_range:
return spmi_regulator_select_voltage(vreg, min_uV, max_uV);