diff options
| author | Ursula Braun <braunu@de.ibm.com> | 2008-04-24 10:15:20 +0200 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-29 01:56:29 -0400 |
| commit | 022b660ae5d075ed9eaddef6f6fb7abb48bdf63b (patch) | |
| tree | 9520e014a156da3d70f26e859d4e9b838602f79b /drivers/s390/net/cu3088.c | |
| parent | 8bbf84404b02f193c5422c252264d7b82ffe4443 (diff) | |
| download | linux-022b660ae5d075ed9eaddef6f6fb7abb48bdf63b.tar.gz linux-022b660ae5d075ed9eaddef6f6fb7abb48bdf63b.tar.bz2 linux-022b660ae5d075ed9eaddef6f6fb7abb48bdf63b.zip | |
ccwgroup: Unify parsing for group attribute.
Instead of having each driver for ccwgroup slave device parsing the
input itself and calling ccwgroup_create(), introduce a new function
ccwgroup_create_from_string() and handle parsing inside the ccwgroup
core.
Signed-off-by: Ursula Braun <braunu@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/s390/net/cu3088.c')
| -rw-r--r-- | drivers/s390/net/cu3088.c | 20 |
1 files changed, 2 insertions, 18 deletions
diff --git a/drivers/s390/net/cu3088.c b/drivers/s390/net/cu3088.c index 76728ae4b843..8e7697305a4c 100644 --- a/drivers/s390/net/cu3088.c +++ b/drivers/s390/net/cu3088.c @@ -62,30 +62,14 @@ static struct device *cu3088_root_dev; static ssize_t group_write(struct device_driver *drv, const char *buf, size_t count) { - const char *start, *end; - char bus_ids[2][BUS_ID_SIZE], *argv[2]; - int i; int ret; struct ccwgroup_driver *cdrv; cdrv = to_ccwgroupdrv(drv); if (!cdrv) return -EINVAL; - start = buf; - for (i=0; i<2; i++) { - static const char delim[] = {',', '\n'}; - int len; - - if (!(end = strchr(start, delim[i]))) - return -EINVAL; - len = min_t(ptrdiff_t, BUS_ID_SIZE, end - start + 1); - strlcpy (bus_ids[i], start, len); - argv[i] = bus_ids[i]; - start = end + 1; - } - - ret = ccwgroup_create(cu3088_root_dev, cdrv->driver_id, - &cu3088_driver, 2, argv); + ret = ccwgroup_create_from_string(cu3088_root_dev, cdrv->driver_id, + &cu3088_driver, 2, buf); return (ret == 0) ? count : ret; } |