diff options
| author | Vijay Mohan Guvva <vmohan@Brocade.com> | 2013-05-13 03:49:44 -0600 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2013-06-04 11:16:25 -0700 |
| commit | 111ecbe426241bdc89c33e9acd08eb15744ce031 (patch) | |
| tree | 4f4add6a338b5bdb1a1468c1914afa877e955c3b /drivers/scsi/bfa/bfa_svc.c | |
| parent | 0816c9251a7180383bb7811e1a1545f7b78e5374 (diff) | |
| download | linux-111ecbe426241bdc89c33e9acd08eb15744ce031.tar.gz linux-111ecbe426241bdc89c33e9acd08eb15744ce031.tar.bz2 linux-111ecbe426241bdc89c33e9acd08eb15744ce031.zip | |
[SCSI] bfa: fix faulty handling of events in lps sm
When a switch disable/enable or a reboot is done, the HBA port gets an
offline and a subsequent online notification. When the port comes up a
link up notification is sent to bfa from the firmware. The bfa then send
an FLOGI to the firmware which is sent out on the wire.
The switch port meanwhile goes offline (presumably for diagnostics)
which causes the switch not to respond to the FLOGI.
The link down notification is sent to the HBA driver. However owing to a
bug in the lps state machine handling the lps state machine does not
move to sm_init state (it remains in sm_login state and send a login
complete message to fcs). This results in a zero PID assignment as the
login is not really complete.
This fix is to correctly handle the events in lps state machine.
Signed-off-by: Vijaya Mohan Guvva <vmohan@brocade.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/bfa/bfa_svc.c')
| -rw-r--r-- | drivers/scsi/bfa/bfa_svc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/bfa/bfa_svc.c b/drivers/scsi/bfa/bfa_svc.c index 299c1c889b33..7ed2c57d8736 100644 --- a/drivers/scsi/bfa/bfa_svc.c +++ b/drivers/scsi/bfa/bfa_svc.c @@ -1276,7 +1276,6 @@ bfa_lps_sm_login(struct bfa_lps_s *lps, enum bfa_lps_event event) switch (event) { case BFA_LPS_SM_FWRSP: - case BFA_LPS_SM_OFFLINE: if (lps->status == BFA_STATUS_OK) { bfa_sm_set_state(lps, bfa_lps_sm_online); if (lps->fdisc) @@ -1305,6 +1304,7 @@ bfa_lps_sm_login(struct bfa_lps_s *lps, enum bfa_lps_event event) bfa_lps_login_comp(lps); break; + case BFA_LPS_SM_OFFLINE: case BFA_LPS_SM_DELETE: bfa_sm_set_state(lps, bfa_lps_sm_init); break; |