summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/bnx2fc
diff options
context:
space:
mode:
authorJules Irenge <jbi.octave@gmail.com>2020-04-11 01:19:31 +0100
committerMartin K. Petersen <martin.petersen@oracle.com>2020-04-24 12:56:37 -0400
commitbc834e074e36262d62a9e26742ed5a5246a469eb (patch)
treeb9b90c6b6017a724cf059e191e661a71242942a9 /drivers/scsi/bnx2fc
parentd1ec20a55f6c8ce485fd298a015ec83d7e5326d8 (diff)
downloadlinux-bc834e074e36262d62a9e26742ed5a5246a469eb.tar.gz
linux-bc834e074e36262d62a9e26742ed5a5246a469eb.tar.bz2
linux-bc834e074e36262d62a9e26742ed5a5246a469eb.zip
scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup()
Sparse reports the following warning: warning: context imbalance in bnx2fc_abts_cleanup() - unexpected unlock The root cause is the missing annotation at bnx2fc_abts_cleanup(). Add the missing __must_hold(&tgt->tgt_lock) annotation. Link: https://lore.kernel.org/r/20200411001933.10072-8-jbi.octave@gmail.com Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/bnx2fc')
-rw-r--r--drivers/scsi/bnx2fc/bnx2fc_io.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
index 2b070f0835df..1aba5897ccb0 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_io.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
@@ -1081,6 +1081,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd)
}
static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)
+ __must_hold(&tgt->tgt_lock)
{
struct bnx2fc_rport *tgt = io_req->tgt;
unsigned int time_left;