summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/device_handler
diff options
context:
space:
mode:
authorIlgu Hong <ilgu.hong@promise.com>2009-01-30 17:00:09 -0600
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2009-03-12 12:58:11 -0500
commitef3fa8c6a2e7c53dbaf2eb33a09ad05177425f12 (patch)
treec5c3642c4b3c981ff810b0292cd69ae644d2056b /drivers/scsi/device_handler
parentf078727b250c2653fc9a564f15547c17ebac3f99 (diff)
downloadlinux-ef3fa8c6a2e7c53dbaf2eb33a09ad05177425f12.tar.gz
linux-ef3fa8c6a2e7c53dbaf2eb33a09ad05177425f12.tar.bz2
linux-ef3fa8c6a2e7c53dbaf2eb33a09ad05177425f12.zip
[SCSI] scsi dh alua: fix group id masking
The buf[i] is a byte but we are only asking 4 bits off the group_id. This patch has us take off a byte. Signed-off-by: Ilgu Hong <ilgu.hong@promise.com> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi/device_handler')
-rw-r--r--drivers/scsi/device_handler/scsi_dh_alua.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index e356b43753ff..5096b0bf00e2 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -247,8 +247,8 @@ static unsigned submit_stpg(struct scsi_device *sdev, struct alua_dh_data *h)
/* Prepare the data buffer */
memset(h->buff, 0, stpg_len);
h->buff[4] = TPGS_STATE_OPTIMIZED & 0x0f;
- h->buff[6] = (h->group_id >> 8) & 0x0f;
- h->buff[7] = h->group_id & 0x0f;
+ h->buff[6] = (h->group_id >> 8) & 0xff;
+ h->buff[7] = h->group_id & 0xff;
rq = get_alua_req(sdev, h->buff, stpg_len, WRITE);
if (!rq)