diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-06-18 16:43:59 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2021-06-18 23:01:04 -0400 |
| commit | 7cca85dff2d2a67836ecb2f4bf6466bc5080e007 (patch) | |
| tree | 2ff1a422c733faf8ff076609cfafbfe6d5a893ad /drivers/scsi/elx | |
| parent | 99cf922692021823bd2f87aa307fa6cb28e91ad1 (diff) | |
| download | linux-7cca85dff2d2a67836ecb2f4bf6466bc5080e007.tar.gz linux-7cca85dff2d2a67836ecb2f4bf6466bc5080e007.tar.bz2 linux-7cca85dff2d2a67836ecb2f4bf6466bc5080e007.zip | |
scsi: elx: libefc: Fix IRQ restore in efc_domain_dispatch_frame()
Calling a nested spin_lock_irqsave() will overwrite the original "flags" so
that they can not be enabled again at the end.
Link: https://lore.kernel.org/r/YMyjH16k4M1yEmmU@mwanda
Fixes: 3146240f19bf ("scsi: elx: libefc: FC Domain state machine interfaces")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/elx')
| -rw-r--r-- | drivers/scsi/elx/libefc/efc_domain.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/elx/libefc/efc_domain.c b/drivers/scsi/elx/libefc/efc_domain.c index 0c08fa2066b9..ca9d7ff2c0d2 100644 --- a/drivers/scsi/elx/libefc/efc_domain.c +++ b/drivers/scsi/elx/libefc/efc_domain.c @@ -1001,10 +1001,10 @@ efc_domain_dispatch_frame(void *arg, struct efc_hw_sequence *seq) if (node->hold_frames || !list_empty(&node->pend_frames)) { /* add frame to node's pending list */ - spin_lock_irqsave(&node->pend_frames_lock, flags); + spin_lock(&node->pend_frames_lock); INIT_LIST_HEAD(&seq->list_entry); list_add_tail(&seq->list_entry, &node->pend_frames); - spin_unlock_irqrestore(&node->pend_frames_lock, flags); + spin_unlock(&node->pend_frames_lock); rc = EFC_HW_SEQ_HOLD; goto out_release; } |