summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/mpi3mr
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2022-05-06 16:17:33 +0300
committerMartin K. Petersen <martin.petersen@oracle.com>2022-05-16 21:30:17 -0400
commita25eafd13e5f79d9bbada5a4a4a4224cc5f6d14c (patch)
tree879260ee64ad3a4f47f92ccd797e77e913f3ff22 /drivers/scsi/mpi3mr
parent20f8932f979e7377a625f6e711bd4e84ec025d0b (diff)
downloadlinux-a25eafd13e5f79d9bbada5a4a4a4224cc5f6d14c.tar.gz
linux-a25eafd13e5f79d9bbada5a4a4a4224cc5f6d14c.tar.bz2
linux-a25eafd13e5f79d9bbada5a4a4a4224cc5f6d14c.zip
scsi: mpi3mr: Fix a NULL vs IS_ERR() bug in mpi3mr_bsg_init()
The bsg_setup_queue() function does not return NULL. It returns error pointers. Fix the check accordingly. Link: https://lore.kernel.org/r/YnUf7RQl+A3tigWh@kili Fixes: 4268fa751365 ("scsi: mpi3mr: Add bsg device support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/mpi3mr')
-rw-r--r--drivers/scsi/mpi3mr/mpi3mr_app.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/mpi3mr/mpi3mr_app.c b/drivers/scsi/mpi3mr/mpi3mr_app.c
index 73bb7992d5a8..8138a728d1ab 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_app.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_app.c
@@ -1540,7 +1540,7 @@ void mpi3mr_bsg_init(struct mpi3mr_ioc *mrioc)
mrioc->bsg_queue = bsg_setup_queue(mrioc->bsg_dev, dev_name(mrioc->bsg_dev),
mpi3mr_bsg_request, NULL, 0);
- if (!mrioc->bsg_queue) {
+ if (IS_ERR(mrioc->bsg_queue)) {
ioc_err(mrioc, "%s: bsg registration failed\n",
dev_name(mrioc->bsg_dev));
goto err_setup_queue;