diff options
| author | Mike Maslenkin <mihailm@parallels.com> | 2012-04-28 05:32:14 +0400 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2012-05-10 09:06:12 +0100 |
| commit | 89a342ca6bfc1a014ff50cce5659abc58e11ecfc (patch) | |
| tree | e6e7760d0b953f3f76f3dfd7d16bbcbddca3ab26 /drivers/scsi/scsi_transport_spi.c | |
| parent | 9ebd99c599bcb125acde9b3c98383ebd6e208bc1 (diff) | |
| download | linux-89a342ca6bfc1a014ff50cce5659abc58e11ecfc.tar.gz linux-89a342ca6bfc1a014ff50cce5659abc58e11ecfc.tar.bz2 linux-89a342ca6bfc1a014ff50cce5659abc58e11ecfc.zip | |
[SCSI] scsi_transport_spi: fix for unbalanced reference counting
Check the domain validation flag on the given device before referencing
scsi_device instance, otherwise if the flag is already set we return without
decrementing the reference count.
Signed-off-by: Mike Maslenkin <mihailm@parallels.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/scsi_transport_spi.c')
| -rw-r--r-- | drivers/scsi/scsi_transport_spi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c index a2715c31e754..cf08071a9b6e 100644 --- a/drivers/scsi/scsi_transport_spi.c +++ b/drivers/scsi/scsi_transport_spi.c @@ -1010,10 +1010,10 @@ spi_dv_device(struct scsi_device *sdev) u8 *buffer; const int len = SPI_MAX_ECHO_BUFFER_SIZE*2; - if (unlikely(scsi_device_get(sdev))) + if (unlikely(spi_dv_in_progress(starget))) return; - if (unlikely(spi_dv_in_progress(starget))) + if (unlikely(scsi_device_get(sdev))) return; spi_dv_in_progress(starget) = 1; |