diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-04-10 20:37:59 +0800 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2018-04-20 19:14:37 -0400 |
| commit | 1f618aac2f00d3d9a4942cda14b8c33d28a11840 (patch) | |
| tree | 2130ad081ce9e1a363af077d6dc7898b7acb77a0 /drivers/scsi/st.c | |
| parent | c360652006bba40837cf16d5099ea61f7ce16c63 (diff) | |
| download | linux-1f618aac2f00d3d9a4942cda14b8c33d28a11840.tar.gz linux-1f618aac2f00d3d9a4942cda14b8c33d28a11840.tar.bz2 linux-1f618aac2f00d3d9a4942cda14b8c33d28a11840.zip | |
scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in st_probe
st_probe() is never called in atomic context. st_probe() is only set as
".probe" in struct scsi_driver.
Despite never getting called from atomic context, st_probe() calls
kzalloc() with GFP_ATOMIC, which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which
can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/st.c')
| -rw-r--r-- | drivers/scsi/st.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 6c399480783d..4c7d39b825a3 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -4290,7 +4290,7 @@ static int st_probe(struct device *dev) goto out_buffer_free; } - tpnt = kzalloc(sizeof(struct scsi_tape), GFP_ATOMIC); + tpnt = kzalloc(sizeof(struct scsi_tape), GFP_KERNEL); if (tpnt == NULL) { sdev_printk(KERN_ERR, SDp, "st: Can't allocate device descriptor.\n"); |