diff options
| author | Helge Deller <deller@gmx.de> | 2017-08-10 21:08:49 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-08-24 22:28:54 -0400 |
| commit | c0e8ed04b32307c192bcf37f5810e490e4d2739e (patch) | |
| tree | 6307e7ef8c5eaa37cc02af29215d14dd2b37f438 /drivers/scsi/sym53c8xx_2/sym_hipd.c | |
| parent | 8a97712e5314aefe16b3ffb4583a34deaa49de04 (diff) | |
| download | linux-c0e8ed04b32307c192bcf37f5810e490e4d2739e.tar.gz linux-c0e8ed04b32307c192bcf37f5810e490e4d2739e.tar.bz2 linux-c0e8ed04b32307c192bcf37f5810e490e4d2739e.zip | |
scsi: sym53c8xx: Avoid undefined behaviour
On parisc I see this UBSAN warning with a sym53c896:
UBSAN: Undefined behaviour in ./drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24
index -1903078336 is out of range for type 'u32 [7]'
Avoid this warning by switching to div64_ul().
[mkp: fix typo]
Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/sym53c8xx_2/sym_hipd.c')
| -rw-r--r-- | drivers/scsi/sym53c8xx_2/sym_hipd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/sym53c8xx_2/sym_hipd.c b/drivers/scsi/sym53c8xx_2/sym_hipd.c index 6b349e301869..15ff285a9f8f 100644 --- a/drivers/scsi/sym53c8xx_2/sym_hipd.c +++ b/drivers/scsi/sym53c8xx_2/sym_hipd.c @@ -759,7 +759,7 @@ static int sym_prepare_setting(struct Scsi_Host *shost, struct sym_hcb *np, stru /* * Maximum synchronous period factor supported by the chip. */ - period = (11 * div_10M[np->clock_divn - 1]) / (4 * np->clock_khz); + period = div64_ul(11 * div_10M[np->clock_divn - 1], 4 * np->clock_khz); np->maxsync = period > 2540 ? 254 : period / 10; /* |