diff options
| author | Jeff Garzik <jgarzik@pobox.com> | 2005-05-28 07:47:39 -0400 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@pobox.com> | 2005-06-17 12:04:37 -0500 |
| commit | e3df715501be3329986e5d9dfa9a477f49e7996b (patch) | |
| tree | 3602c4bbca8bca9b615b93099de53717bc932591 /drivers/scsi | |
| parent | 12021fff2bae7fab01c4bf283f3cd9bc6997d8c4 (diff) | |
| download | linux-e3df715501be3329986e5d9dfa9a477f49e7996b.tar.gz linux-e3df715501be3329986e5d9dfa9a477f49e7996b.tar.bz2 linux-e3df715501be3329986e5d9dfa9a477f49e7996b.zip | |
[SCSI] Remove unnecessary locking around completion function calls
The SCSI ->done() hook should not be called from inside a spinlock.
Drivers that do this are mostly cut-n-paste from 2.2.x-era.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/ultrastor.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/ultrastor.c b/drivers/scsi/ultrastor.c index 97f4d9112b48..2c17470a229d 100644 --- a/drivers/scsi/ultrastor.c +++ b/drivers/scsi/ultrastor.c @@ -954,9 +954,7 @@ static int ultrastor_abort(Scsi_Cmnd *SCpnt) SCpnt->result = DID_ABORT << 16; /* Take the host lock to guard against scsi layer re-entry */ - spin_lock_irqsave(host->host_lock, flags); done(SCpnt); - spin_unlock_irqrestore(host->host_lock, flags); /* Need to set a timeout here in case command never completes. */ return SUCCESS; |