summaryrefslogtreecommitdiffstats
path: root/drivers/siox
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2020-11-25 10:31:06 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-12-10 16:17:15 +0100
commit1c12c27086dcef853832a7cbebcb48bdac8104b6 (patch)
tree933eaa6521bf08c89ce5717bcb711a24bd51ff11 /drivers/siox
parent07d9a767ae5c3a9b0cf1adccbf157a6fae780de4 (diff)
downloadlinux-1c12c27086dcef853832a7cbebcb48bdac8104b6.tar.gz
linux-1c12c27086dcef853832a7cbebcb48bdac8104b6.tar.bz2
linux-1c12c27086dcef853832a7cbebcb48bdac8104b6.zip
siox: Make remove callback return void
The driver core ignores the return value of the remove callback, so don't give siox drivers the chance to provide a value. All siox drivers only allocate devm-managed resources in .probe, so there is no .remove callback to fix. Tested-by: Thorsten Scherer <t.scherer@eckelmann.de> Acked-by: Thorsten Scherer <t.scherer@eckelmann.de> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20201125093106.240643-3-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/siox')
-rw-r--r--drivers/siox/siox-core.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
index b56cdcb52967..1794ff0106bc 100644
--- a/drivers/siox/siox-core.c
+++ b/drivers/siox/siox-core.c
@@ -525,12 +525,11 @@ static int siox_remove(struct device *dev)
struct siox_driver *sdriver =
container_of(dev->driver, struct siox_driver, driver);
struct siox_device *sdevice = to_siox_device(dev);
- int ret = 0;
if (sdriver->remove)
- ret = sdriver->remove(sdevice);
+ sdriver->remove(sdevice);
- return ret;
+ return 0;
}
static void siox_shutdown(struct device *dev)