diff options
| author | Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2021-12-30 09:45:43 +0800 |
|---|---|---|
| committer | Li Yang <leoyang.li@nxp.com> | 2022-02-18 17:11:23 -0600 |
| commit | a222fd8541394b36b13c89d1698d9530afd59a9c (patch) | |
| tree | 93346033ec7ea2f4ea20dd40fd02b051cb0d34f5 /drivers/soc | |
| parent | 6385960501d9e0248a8745714674e86bd077e198 (diff) | |
| download | linux-a222fd8541394b36b13c89d1698d9530afd59a9c.tar.gz linux-a222fd8541394b36b13c89d1698d9530afd59a9c.tar.bz2 linux-a222fd8541394b36b13c89d1698d9530afd59a9c.zip | |
soc: fsl: qe: Check of ioremap return value
As the possible failure of the ioremap(), the par_io could be NULL.
Therefore it should be better to check it and return error in order to
guarantee the success of the initiation.
But, I also notice that all the caller like mpc85xx_qe_par_io_init() in
`arch/powerpc/platforms/85xx/common.c` don't check the return value of
the par_io_init().
Actually, par_io_init() needs to check to handle the potential error.
I will submit another patch to fix that.
Anyway, par_io_init() itsely should be fixed.
Fixes: 7aa1aa6ecec2 ("QE: Move QE from arch/powerpc to drivers/soc")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Diffstat (limited to 'drivers/soc')
| -rw-r--r-- | drivers/soc/fsl/qe/qe_io.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/soc/fsl/qe/qe_io.c b/drivers/soc/fsl/qe/qe_io.c index e277c827bdf3..a5e2d0e5ab51 100644 --- a/drivers/soc/fsl/qe/qe_io.c +++ b/drivers/soc/fsl/qe/qe_io.c @@ -35,6 +35,8 @@ int par_io_init(struct device_node *np) if (ret) return ret; par_io = ioremap(res.start, resource_size(&res)); + if (!par_io) + return -ENOMEM; if (!of_property_read_u32(np, "num-ports", &num_ports)) num_par_io_ports = num_ports; |