summaryrefslogtreecommitdiffstats
path: root/drivers/spi/spi-bcm2835.c
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2013-08-22 23:19:07 +0800
committerMark Brown <broonie@linaro.org>2013-08-22 19:07:51 +0100
commit7bc003100b61cdfe0515fe907010fe822353d924 (patch)
tree9728df84bb395e8b7c14b5ba31c62e0cc8fb727d /drivers/spi/spi-bcm2835.c
parentc2b6a3a82d630574cc1ad859722d507a1fde889a (diff)
downloadlinux-7bc003100b61cdfe0515fe907010fe822353d924.tar.gz
linux-7bc003100b61cdfe0515fe907010fe822353d924.tar.bz2
linux-7bc003100b61cdfe0515fe907010fe822353d924.zip
spi: bcm2835: Add spi_master_get() call to prevent use after free
The call to spi_unregister_master results in device memory being freed, it must no longer be accessed afterwards. Thus call spi_master_get() to get an extra reference to the device and call spi_master_put() only after the last access to device data. Note, current code has an extra spi_master_put() call in bcm2835_spi_remove(). Thus this patch just adds an spi_master_get() to balance the reference count. Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'drivers/spi/spi-bcm2835.c')
-rw-r--r--drivers/spi/spi-bcm2835.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
index 7de617aba695..52c81481c5c7 100644
--- a/drivers/spi/spi-bcm2835.c
+++ b/drivers/spi/spi-bcm2835.c
@@ -377,7 +377,7 @@ out_master_put:
static int bcm2835_spi_remove(struct platform_device *pdev)
{
- struct spi_master *master = platform_get_drvdata(pdev);
+ struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));
struct bcm2835_spi *bs = spi_master_get_devdata(master);
free_irq(bs->irq, master);