diff options
| author | Ian Abbott <abbotti@mev.co.uk> | 2013-05-10 14:07:16 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-05-13 17:38:48 -0400 |
| commit | e9166139f6f829c2e7bf6695f13e08d09303d6ca (patch) | |
| tree | fedc60a4cc8493b508a3432d915c9f01b554b3f7 /drivers/staging | |
| parent | bd304a736afd99cc38bad4d1628e8e2d05d308d5 (diff) | |
| download | linux-e9166139f6f829c2e7bf6695f13e08d09303d6ca.tar.gz linux-e9166139f6f829c2e7bf6695f13e08d09303d6ca.tar.bz2 linux-e9166139f6f829c2e7bf6695f13e08d09303d6ca.zip | |
staging: comedi: complain if dma buffer allocation not supported
When allocating a buffer to support asynchronous comedi commands, if a
DMA coherent buffer was requested but `CONFIG_HAS_DMA` is undefined,
bail out of local helper function `__comedi_buf_alloc()` with an error
message.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/comedi/comedi_buf.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/staging/comedi/comedi_buf.c b/drivers/staging/comedi/comedi_buf.c index b6cd67ad55d1..d4be0e68509b 100644 --- a/drivers/staging/comedi/comedi_buf.c +++ b/drivers/staging/comedi/comedi_buf.c @@ -76,6 +76,12 @@ static void __comedi_buf_alloc(struct comedi_device *dev, struct comedi_buf_page *buf; unsigned i; + if (!IS_ENABLED(CONFIG_HAS_DMA) && s->async_dma_dir != DMA_NONE) { + dev_err(dev->class_dev, + "dma buffer allocation not supported\n"); + return; + } + async->buf_page_list = vzalloc(sizeof(*buf) * n_pages); if (async->buf_page_list) pages = vmalloc(sizeof(struct page *) * n_pages); |