diff options
author | Paolo Bonzini <pbonzini@redhat.com> | 2012-09-07 17:30:33 +0200 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-09-07 11:09:08 -0700 |
commit | 0d7f1299ca5540b9a63ab6e8bf0e89ea963eb6af (patch) | |
tree | 25bba610d95a2d7256830eb41032e5b1e2853fd4 /drivers/target/target_core_alua.c | |
parent | 306c11b28d7bb85a7adda741798a2b6b60dd305a (diff) | |
download | linux-0d7f1299ca5540b9a63ab6e8bf0e89ea963eb6af.tar.gz linux-0d7f1299ca5540b9a63ab6e8bf0e89ea963eb6af.tar.bz2 linux-0d7f1299ca5540b9a63ab6e8bf0e89ea963eb6af.zip |
target: report too-small parameter lists everywhere
Several places were not checking that the parameter list length
was large enough, and thus accessing invalid memory. Zero-length
parameter lists are just a special case of this.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_alua.c')
-rw-r--r-- | drivers/target/target_core_alua.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c index 91799973081a..41641ba54828 100644 --- a/drivers/target/target_core_alua.c +++ b/drivers/target/target_core_alua.c @@ -218,6 +218,13 @@ int target_emulate_set_target_port_groups(struct se_cmd *cmd) cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; return -EINVAL; } + if (cmd->data_length < 4) { + pr_warn("SET TARGET PORT GROUPS parameter list length %u too" + " small\n", cmd->data_length); + cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; + return -EINVAL; + } + buf = transport_kmap_data_sg(cmd); /* |