summaryrefslogtreecommitdiffstats
path: root/drivers/target/tcm_fc/tfc_sess.c
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2012-08-18 15:44:09 -0700
committerNicholas Bellinger <nab@linux-iscsi.org>2012-08-20 14:52:11 -0700
commit6de7145ca3db231a84b7516a6cb25878da6ebb19 (patch)
tree3958d4cf730acc08fb9f9f1ad3be4cb132eca17e /drivers/target/tcm_fc/tfc_sess.c
parent74f4cf290918f05b6489aa732dfb08aa5606b9d6 (diff)
downloadlinux-6de7145ca3db231a84b7516a6cb25878da6ebb19.tar.gz
linux-6de7145ca3db231a84b7516a6cb25878da6ebb19.tar.bz2
linux-6de7145ca3db231a84b7516a6cb25878da6ebb19.zip
tcm_vhost: Fix vhost_scsi_target structure alignment
Here TRANSPORT_IQN_LEN is 224, which is a multiple of 4. Since vhost_tpgt is 2 bytes and abi_version is 4, the total size would be 230. But gcc needs struct size be aligned to first field size, which is 4 bytes, so it pads the structure by extra 2 bytes to the total of 232. This padding is very undesirable in an ABI: - it can not be initialized easily - it can not be checked easily - it can leak information between kernel and userspace Simplest solution is probably just to make the padding explicit. (v2: Add check for zero'ed backend->reserved field for VHOST_SCSI_SET_ENDPOINT and VHOST_SCSI_CLEAR_ENDPOINT ops as requested by MST) Reported-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/tcm_fc/tfc_sess.c')
0 files changed, 0 insertions, 0 deletions