summaryrefslogtreecommitdiffstats
path: root/drivers/tty
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2021-04-21 11:54:58 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-04-22 12:09:25 +0200
commit6e560913aae066d532e48beeb7224aa3339f8d8e (patch)
tree5a93a41df9dffdb3b641c3e29f0e963a040abb16 /drivers/tty
parentb8555963ca1abf94b0f69b5f67d208aa78471795 (diff)
downloadlinux-6e560913aae066d532e48beeb7224aa3339f8d8e.tar.gz
linux-6e560913aae066d532e48beeb7224aa3339f8d8e.tar.bz2
linux-6e560913aae066d532e48beeb7224aa3339f8d8e.zip
serial: mpc52xx_uart: drop low-latency workaround
Commit fbe543b412ce ("Fix a potential issue in mpc52xx uart driver") worked around the infamous low_latency behaviour of tty_flip_buffer_push() by simply dropping and reacquiring the port lock in the interrupt handler. Since commit a9c3f68f3cd8 ("tty: Fix low_latency BUG"), tty_flip_buffer_push() always schedules a work item to push data to the line discipline and there's no need to keep any low_latency hacks around. Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://lore.kernel.org/r/20210421095509.3024-16-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r--drivers/tty/serial/mpc52xx_uart.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial/mpc52xx_uart.c
index af1700445251..2704dc988e4a 100644
--- a/drivers/tty/serial/mpc52xx_uart.c
+++ b/drivers/tty/serial/mpc52xx_uart.c
@@ -1421,9 +1421,7 @@ mpc52xx_uart_int_rx_chars(struct uart_port *port)
}
}
- spin_unlock(&port->lock);
tty_flip_buffer_push(tport);
- spin_lock(&port->lock);
return psc_ops->raw_rx_rdy(port);
}