diff options
| author | Liu Jian <liujian56@huawei.com> | 2019-01-23 06:45:37 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-01-31 16:36:36 +0100 |
| commit | 1a392b3de7c5747506b38fc14b2e79977d3c7770 (patch) | |
| tree | 12a7e40cb216694680b08b9490bfad4f39d33802 /drivers/uio | |
| parent | 9bfd8198ba948e11a0f9c618db00b0d4020b71c5 (diff) | |
| download | linux-1a392b3de7c5747506b38fc14b2e79977d3c7770.tar.gz linux-1a392b3de7c5747506b38fc14b2e79977d3c7770.tar.bz2 linux-1a392b3de7c5747506b38fc14b2e79977d3c7770.zip | |
driver: uio: fix possible memory leak in __uio_register_device
'idev' is malloced in __uio_register_device() and leak free it before
leaving from the uio_get_minor() error handing case, it will cause
memory leak.
Fixes: a93e7b331568 ("uio: Prevent device destruction while fds are open")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Reviewed-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/uio')
| -rw-r--r-- | drivers/uio/uio.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index effe72834c2f..f23ef235359f 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -940,8 +940,10 @@ int __uio_register_device(struct module *owner, atomic_set(&idev->event, 0); ret = uio_get_minor(idev); - if (ret) + if (ret) { + kfree(idev); return ret; + } idev->dev.devt = MKDEV(uio_major, idev->minor); idev->dev.class = &uio_class; |