summaryrefslogtreecommitdiffstats
path: root/drivers/usb/gadget
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2014-07-16 12:19:12 -0500
committerFelipe Balbi <balbi@ti.com>2014-07-16 12:50:40 -0500
commitbbb9f94cf9e9e1cd120ef757944f0304a89aac95 (patch)
treecb83eb4d47c5b0c5ee2585ada77928f2d05107b4 /drivers/usb/gadget
parent00a2430ff07d4e0e0e7e24e02fd8adede333b797 (diff)
downloadlinux-bbb9f94cf9e9e1cd120ef757944f0304a89aac95.tar.gz
linux-bbb9f94cf9e9e1cd120ef757944f0304a89aac95.tar.bz2
linux-bbb9f94cf9e9e1cd120ef757944f0304a89aac95.zip
usb: gadget: udc: fsl_udc_core: fix sparse errors
No functional changes, just fixing some easy to spot sparse errors. Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/gadget')
-rw-r--r--drivers/usb/gadget/udc/fsl_udc_core.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
index 57944ee8ad90..75b23ea077a7 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -59,9 +59,9 @@
static const char driver_name[] = "fsl-usb2-udc";
static const char driver_desc[] = DRIVER_DESC;
-static struct usb_dr_device *dr_regs;
+static struct usb_dr_device __iomem *dr_regs;
-static struct usb_sys_interface *usb_sys_regs;
+static struct usb_sys_interface __iomem *usb_sys_regs;
/* it is initialized in probe() */
static struct fsl_udc *udc_controller = NULL;
@@ -159,6 +159,8 @@ static inline void fsl_set_accessors(struct fsl_usb2_platform_data *pdata) {}
* request is still in progress.
*--------------------------------------------------------------*/
static void done(struct fsl_ep *ep, struct fsl_req *req, int status)
+__releases(ep->udc->lock)
+__acquires(ep->udc->lock)
{
struct fsl_udc *udc = NULL;
unsigned char stopped = ep->stopped;
@@ -1392,6 +1394,8 @@ stall:
static void setup_received_irq(struct fsl_udc *udc,
struct usb_ctrlrequest *setup)
+__releases(udc->lock)
+__acquires(udc->lock)
{
u16 wValue = le16_to_cpu(setup->wValue);
u16 wIndex = le16_to_cpu(setup->wIndex);
@@ -1957,7 +1961,7 @@ static int fsl_udc_start(struct usb_gadget *g,
&udc_controller->gadget);
if (retval < 0) {
ERR("can't bind to transceiver\n");
- udc_controller->driver = 0;
+ udc_controller->driver = NULL;
return retval;
}
}
@@ -2379,7 +2383,7 @@ static int fsl_udc_probe(struct platform_device *pdev)
goto err_release_mem_region;
}
- pdata->regs = (void *)dr_regs;
+ pdata->regs = (void __iomem *)dr_regs;
/*
* do platform specific init: check the clock, grab/config pins, etc.