diff options
| author | Alan Stern <stern@rowland.harvard.edu> | 2008-01-10 16:43:15 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-02-01 14:35:03 -0800 |
| commit | f8fa7571a928d6d0e1b7444b0ea69ec7dc7db3b6 (patch) | |
| tree | 644e9536379f9d13ad9fab1bbe6005a75bd7fd61 /drivers/usb/host/ehci-hub.c | |
| parent | dd95b814115e45e0bf800f2950b9941c86e68172 (diff) | |
| download | linux-f8fa7571a928d6d0e1b7444b0ea69ec7dc7db3b6.tar.gz linux-f8fa7571a928d6d0e1b7444b0ea69ec7dc7db3b6.tar.bz2 linux-f8fa7571a928d6d0e1b7444b0ea69ec7dc7db3b6.zip | |
USB: EHCI: move del_timer_sync calls outside spinlocked region
This patch (as1030b) moves a del_timer_sync() call outside the scope of a
spinlock, where it could cause a deadlock, and adds a new
del_timer_sync() call for the new IAA watchdog timer (it was omitted
by mistake).
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/host/ehci-hub.c')
| -rw-r--r-- | drivers/usb/host/ehci-hub.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c index a249d03a5024..7919a411d5f9 100644 --- a/drivers/usb/host/ehci-hub.c +++ b/drivers/usb/host/ehci-hub.c @@ -123,6 +123,8 @@ static int ehci_bus_suspend (struct usb_hcd *hcd) if (time_before (jiffies, ehci->next_statechange)) msleep(5); + del_timer_sync(&ehci->watchdog); + del_timer_sync(&ehci->iaa_watchdog); port = HCS_N_PORTS (ehci->hcs_params); spin_lock_irq (&ehci->lock); @@ -171,7 +173,6 @@ static int ehci_bus_suspend (struct usb_hcd *hcd) } /* turn off now-idle HC */ - del_timer_sync (&ehci->watchdog); ehci_halt (ehci); hcd->state = HC_STATE_SUSPENDED; |