diff options
| author | Mathias Nyman <mathias.nyman@linux.intel.com> | 2021-01-29 15:00:29 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-01-29 14:16:50 +0100 |
| commit | 0353810a047ef0101af01665f60597d7f5cc6b02 (patch) | |
| tree | 57dfb5e32ef43466986f38c12ed6598a13c5a0fa /drivers/usb/host/xhci.h | |
| parent | 55f6153d8cc8eff0852d108f80087fdf41dc2169 (diff) | |
| download | linux-0353810a047ef0101af01665f60597d7f5cc6b02.tar.gz linux-0353810a047ef0101af01665f60597d7f5cc6b02.tar.bz2 linux-0353810a047ef0101af01665f60597d7f5cc6b02.zip | |
xhci: avoid DMA double fetch when reading event trb type.
Instead of re-reading, masking and endianness correcting the same trb
several times to get the trb type from an event, just do it once and
store it in a local variable.
Also pass the trb_type directly to the vendor specific event handler,
avoiding one more similar read.
In addition to the security benefit this also cleans up the code
and helps readability.
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20210129130044.206855-13-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host/xhci.h')
| -rw-r--r-- | drivers/usb/host/xhci.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index b28a2d9fe35e..87af91447985 100644 --- a/drivers/usb/host/xhci.h +++ b/drivers/usb/host/xhci.h @@ -1419,7 +1419,7 @@ union xhci_trb { /* MFINDEX Wrap Event - microframe counter wrapped */ #define TRB_MFINDEX_WRAP 39 /* TRB IDs 40-47 reserved, 48-63 is vendor-defined */ - +#define TRB_VENDOR_DEFINED_LOW 48 /* Nec vendor-specific command completion event. */ #define TRB_NEC_CMD_COMP 48 /* Get NEC firmware revision. */ |