diff options
| author | Wei Yongjun <weiyj.lk@gmail.com> | 2016-08-13 01:28:24 +0000 |
|---|---|---|
| committer | Felipe Balbi <felipe.balbi@linux.intel.com> | 2016-08-22 10:45:11 +0300 |
| commit | 3295235fd70ed6d594aadee8c892a14f6a4b2d2e (patch) | |
| tree | 70c9caaad86ed1420e13c8a2d340942088be1d11 /drivers/usb/renesas_usbhs | |
| parent | 83f8da562f8b5275fa1095b45762996971f7c607 (diff) | |
| download | linux-3295235fd70ed6d594aadee8c892a14f6a4b2d2e.tar.gz linux-3295235fd70ed6d594aadee8c892a14f6a4b2d2e.tar.bz2 linux-3295235fd70ed6d594aadee8c892a14f6a4b2d2e.zip | |
usb: renesas_usbhs: gadget: fix return value check in usbhs_mod_gadget_probe()
In case of error, the function usb_get_phy() returns ERR_PTR() and never
returns NULL. The NULL test in the return value check should be replaced
with IS_ERR().
Fixes: b5a2875605ca ("usb: renesas_usbhs: Allow an OTG PHY driver to
provide VBUS")
Cc: <stable@vger.kernel.org> # v4.3+
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb/renesas_usbhs')
| -rw-r--r-- | drivers/usb/renesas_usbhs/mod_gadget.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index 92bc83b92d10..c4c64740a3e7 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -1076,7 +1076,7 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) gpriv->transceiver = usb_get_phy(USB_PHY_TYPE_UNDEFINED); dev_info(dev, "%stransceiver found\n", - gpriv->transceiver ? "" : "no "); + !IS_ERR(gpriv->transceiver) ? "" : "no "); /* * CAUTION |