summaryrefslogtreecommitdiffstats
path: root/drivers/usb/storage
diff options
context:
space:
mode:
authorHannes Reinecke <hare@suse.de>2020-05-05 16:30:19 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-05-13 14:20:00 +0200
commitc22eb9374cb0f3936d1942d07e78855fd4e88846 (patch)
tree9ccad62fe147e6239ef043d6f1173861caa382cb /drivers/usb/storage
parent2ca23ae59e997f1b6df7662d8ef10d9c471b46d0 (diff)
downloadlinux-c22eb9374cb0f3936d1942d07e78855fd4e88846.tar.gz
linux-c22eb9374cb0f3936d1942d07e78855fd4e88846.tar.bz2
linux-c22eb9374cb0f3936d1942d07e78855fd4e88846.zip
sierra-ms: do not call scsi_get_host_dev()
scsi_get_host_dev() will create a virtual device such that either the target id is ignored from scanning (if 'this_id' is set to something which can be reached during scanning) or if the driver needs a scsi device for the HBA to send commands to. Neither is true for sierra-ms; 'this_id' remains at the default value '-1' and the created device is never ever used within the driver. So kill it. Signed-off-by: Hannes Reinecke <hare@suse.de> Acked-by: Alan Stern <stern@rowland.harvard.edu> Link: https://lore.kernel.org/r/20200505143019.57418-1-hare@suse.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/storage')
-rw-r--r--drivers/usb/storage/sierra_ms.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/usb/storage/sierra_ms.c b/drivers/usb/storage/sierra_ms.c
index e605cbc3d8bf..b9f78ef3edc3 100644
--- a/drivers/usb/storage/sierra_ms.c
+++ b/drivers/usb/storage/sierra_ms.c
@@ -129,15 +129,11 @@ int sierra_ms_init(struct us_data *us)
int result, retries;
struct swoc_info *swocInfo;
struct usb_device *udev;
- struct Scsi_Host *sh;
retries = 3;
result = 0;
udev = us->pusb_dev;
- sh = us_to_host(us);
- scsi_get_host_dev(sh);
-
/* Force Modem mode */
if (swi_tru_install == TRU_FORCE_MODEM) {
usb_stor_dbg(us, "SWIMS: Forcing Modem Mode\n");