diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2010-02-18 02:36:23 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-03-02 14:55:10 -0800 |
| commit | e4a3d94658b5760fc947d7f7185c57db47ca362a (patch) | |
| tree | ae5d66028e48f96545cce0fd7332f2052ea9baa3 /drivers/usb | |
| parent | b6a2f10ca045c9b0a4732c38485ad6ca1b663bf4 (diff) | |
| download | linux-e4a3d94658b5760fc947d7f7185c57db47ca362a.tar.gz linux-e4a3d94658b5760fc947d7f7185c57db47ca362a.tar.bz2 linux-e4a3d94658b5760fc947d7f7185c57db47ca362a.zip | |
USB: don't read past config->interface[] if usb_control_msg() fails in usb_reset_configuration()
While looping over the interfaces, if usb_hcd_alloc_bandwidth() fails it calls
hcd->driver->reset_bandwidth(), so there was no need to reinstate the interface
again.
If no break occurred, the index equals config->desc.bNumInterfaces. A
subsequent usb_control_msg() failure resulted in a read from
config->interface[config->desc.bNumInterfaces] at label reset_old_alts.
In either case the last interface should be skipped.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/core/message.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index e5d5a2603f3a..cd220277c6c3 100644 --- a/drivers/usb/core/message.c +++ b/drivers/usb/core/message.c @@ -1471,7 +1471,7 @@ int usb_reset_configuration(struct usb_device *dev) /* If not, reinstate the old alternate settings */ if (retval < 0) { reset_old_alts: - for (; i >= 0; i--) { + for (i--; i >= 0; i--) { struct usb_interface *intf = config->interface[i]; struct usb_host_interface *alt; |