diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-05-07 19:50:06 +0800 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2013-05-15 17:25:31 +0300 |
| commit | 481d30427e5506fc1f5c27bbb94faef9d1ec72a0 (patch) | |
| tree | ddefad33841921bd5a51a3128fcc239c17bb1ca0 /drivers/usb | |
| parent | c3661951032d002d710c2187c5d9dbc8b4cabfa2 (diff) | |
| download | linux-481d30427e5506fc1f5c27bbb94faef9d1ec72a0.tar.gz linux-481d30427e5506fc1f5c27bbb94faef9d1ec72a0.tar.bz2 linux-481d30427e5506fc1f5c27bbb94faef9d1ec72a0.zip | |
usb: gadget: dummy_hcd: fix error return code in init()
Fix to return -ENOMEM in the kzalloc() error handling case instead
of 0(following platform_device_add_data() will overwrite it to 0), as
done elsewhere in this function.
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/gadget/dummy_hcd.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c index 22236ecb2e29..c588e8e486e5 100644 --- a/drivers/usb/gadget/dummy_hcd.c +++ b/drivers/usb/gadget/dummy_hcd.c @@ -2660,8 +2660,10 @@ static int __init init(void) } for (i = 0; i < mod_data.num; i++) { dum[i] = kzalloc(sizeof(struct dummy), GFP_KERNEL); - if (!dum[i]) + if (!dum[i]) { + retval = -ENOMEM; goto err_add_pdata; + } retval = platform_device_add_data(the_hcd_pdev[i], &dum[i], sizeof(void *)); if (retval) |