diff options
| author | Stefan Wahren <stefan.wahren@i2se.com> | 2016-07-09 14:16:38 +0000 |
|---|---|---|
| committer | Peter Chen <peter.chen@nxp.com> | 2016-09-14 10:58:13 +0800 |
| commit | 66b76dbe37df88b250ffdac186adba3e5dc24631 (patch) | |
| tree | 2e51bc44f1797c27f57a1a932e3a09ccefcd536f /drivers/usb | |
| parent | 050bc4e846af24e77af82d0fa5f718e0919d15a4 (diff) | |
| download | linux-66b76dbe37df88b250ffdac186adba3e5dc24631.tar.gz linux-66b76dbe37df88b250ffdac186adba3e5dc24631.tar.bz2 linux-66b76dbe37df88b250ffdac186adba3e5dc24631.zip | |
usb: chipidea: udc: move write barrier into hw_ep_prime
Since there should be a write barrier before every call of
hw_ep_prime we could move it into hw_ep_prime.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/chipidea/udc.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index b93356834bb5..b0c4ae1cd206 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -188,6 +188,9 @@ static int hw_ep_prime(struct ci_hdrc *ci, int num, int dir, int is_ctrl) { int n = hw_ep_bit(num, dir); + /* Synchronize before ep prime */ + wmb(); + if (is_ctrl && dir == RX && hw_read(ci, OP_ENDPTSETUPSTAT, BIT(num))) return -EAGAIN; @@ -506,8 +509,6 @@ static int _hardware_enqueue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) hwep->qh.ptr->cap |= mul << __ffs(QH_MULT); } - wmb(); /* synchronize before ep prime */ - ret = hw_ep_prime(ci, hwep->num, hwep->dir, hwep->type == USB_ENDPOINT_XFER_CONTROL); done: @@ -534,9 +535,6 @@ static int reprime_dtd(struct ci_hdrc *ci, struct ci_hw_ep *hwep, hwep->qh.ptr->td.token &= cpu_to_le32(~(TD_STATUS_HALTED | TD_STATUS_ACTIVE)); - /* Synchronize before ep prime */ - wmb(); - return hw_ep_prime(ci, hwep->num, hwep->dir, hwep->type == USB_ENDPOINT_XFER_CONTROL); } |