diff options
| author | Li Jun <jun.li@nxp.com> | 2019-10-09 10:52:28 +0800 |
|---|---|---|
| committer | Peter Chen <peter.chen@nxp.com> | 2019-11-18 16:45:30 +0800 |
| commit | df17aa9fb31f6a41aad37b984909d8ef1a958271 (patch) | |
| tree | d6a2cde8ca9d915431e11ff1a0165134df271621 /drivers/usb | |
| parent | 782c1c49f3dbf335de6b95f2d97b105cca236bc9 (diff) | |
| download | linux-df17aa9fb31f6a41aad37b984909d8ef1a958271.tar.gz linux-df17aa9fb31f6a41aad37b984909d8ef1a958271.tar.bz2 linux-df17aa9fb31f6a41aad37b984909d8ef1a958271.zip | |
usb: chipidea: imx: check data->usbmisc_data against NULL before access
As usbmisc_data is optional, so add the check before access its member,
this fix below static checker warning:
drivers/usb/chipidea/ci_hdrc_imx.c:438 ci_hdrc_imx_probe()
warn: 'data->usbmisc_data' can also be NULL
which is introduced by Patch 15b80f7c3a7f:
"usb: chipidea: imx: enable vbus and id wakeup only for OTG events"
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/chipidea/ci_hdrc_imx.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 2fde44ca4a48..16700170bc34 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -433,13 +433,15 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) goto err_clk; } - if (!IS_ERR(pdata.id_extcon.edev) || - of_property_read_bool(np, "usb-role-switch")) - data->usbmisc_data->ext_id = 1; - - if (!IS_ERR(pdata.vbus_extcon.edev) || - of_property_read_bool(np, "usb-role-switch")) - data->usbmisc_data->ext_vbus = 1; + if (data->usbmisc_data) { + if (!IS_ERR(pdata.id_extcon.edev) || + of_property_read_bool(np, "usb-role-switch")) + data->usbmisc_data->ext_id = 1; + + if (!IS_ERR(pdata.vbus_extcon.edev) || + of_property_read_bool(np, "usb-role-switch")) + data->usbmisc_data->ext_vbus = 1; + } ret = imx_usbmisc_init_post(data->usbmisc_data); if (ret) { |