diff options
| author | Johan Hovold <johan@kernel.org> | 2020-01-17 10:50:25 +0100 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2020-01-17 16:22:58 +0100 |
| commit | 3018dd3fa114b13261e9599ddb5656ef97a1fa17 (patch) | |
| tree | 1c6abd3935cd37de4c6c89cfdf17d05831d3863b /drivers/usb | |
| parent | 1568c58d11a7c851bd09341aeefd6a1c308ac40d (diff) | |
| download | linux-3018dd3fa114b13261e9599ddb5656ef97a1fa17.tar.gz linux-3018dd3fa114b13261e9599ddb5656ef97a1fa17.tar.bz2 linux-3018dd3fa114b13261e9599ddb5656ef97a1fa17.zip | |
USB: serial: keyspan: handle unbound ports
Check for NULL port data in the control URB completion handlers to avoid
dereferencing a NULL pointer in the unlikely case where a port device
isn't bound to a driver (e.g. after an allocation failure on port
probe()).
Fixes: 0ca1268e109a ("USB Serial Keyspan: add support for USA-49WG & USA-28XG")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/serial/keyspan.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c index e66a59ef43a1..aa3dbce22cfb 100644 --- a/drivers/usb/serial/keyspan.c +++ b/drivers/usb/serial/keyspan.c @@ -1058,6 +1058,8 @@ static void usa49_glocont_callback(struct urb *urb) for (i = 0; i < serial->num_ports; ++i) { port = serial->port[i]; p_priv = usb_get_serial_port_data(port); + if (!p_priv) + continue; if (p_priv->resend_cont) { dev_dbg(&port->dev, "%s - sending setup\n", __func__); @@ -1459,6 +1461,8 @@ static void usa67_glocont_callback(struct urb *urb) for (i = 0; i < serial->num_ports; ++i) { port = serial->port[i]; p_priv = usb_get_serial_port_data(port); + if (!p_priv) + continue; if (p_priv->resend_cont) { dev_dbg(&port->dev, "%s - sending setup\n", __func__); |