summaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorArchit Taneja <archit@ti.com>2010-08-02 15:14:11 +0200
committerTomi Valkeinen <tomi.valkeinen@nokia.com>2010-08-05 16:52:18 +0300
commitf3c77d6332d979b74364ce2f3fc027ff6c0e00d1 (patch)
treeff6c57a6c395a1f5fa7adb5b5dc050a9671fce93 /drivers/video
parente9c31afcffe3df90ebac343611b2f0177bf3cbe4 (diff)
downloadlinux-f3c77d6332d979b74364ce2f3fc027ff6c0e00d1.tar.gz
linux-f3c77d6332d979b74364ce2f3fc027ff6c0e00d1.tar.bz2
linux-f3c77d6332d979b74364ce2f3fc027ff6c0e00d1.zip
OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()
The function overlay_manager_store currently fails if the sysfs input is a prefix string of an existing overlay manager name. This occurs because strncmp compares the two strings only till the length of the input sysfs string. So a sysfs input "lcd" will match manager name "lcd2" which is incorrect behavior. The use of sysfs_streq here will prevent this false positive match to occur. Signed-off-by: Archit Taneja <archit@ti.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/omap2/dss/overlay.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/omap2/dss/overlay.c b/drivers/video/omap2/dss/overlay.c
index 82336583adef..244dca81a399 100644
--- a/drivers/video/omap2/dss/overlay.c
+++ b/drivers/video/omap2/dss/overlay.c
@@ -65,7 +65,7 @@ static ssize_t overlay_manager_store(struct omap_overlay *ovl, const char *buf,
for (i = 0; i < omap_dss_get_num_overlay_managers(); ++i) {
mgr = omap_dss_get_overlay_manager(i);
- if (strncmp(buf, mgr->name, len) == 0)
+ if (sysfs_streq(buf, mgr->name))
break;
mgr = NULL;