diff options
| author | Wolfram Sang <wsa+renesas@sang-engineering.com> | 2018-01-14 22:07:10 +0100 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2018-04-30 10:50:44 +0100 |
| commit | bb084c0f61d659f0e6d371b096e0e57998f191d6 (patch) | |
| tree | 43c07d484a7e932350c5224758a90ec87bf078c6 /drivers/video | |
| parent | 3157694d8c7fed9046dece8b63434cafef21cbf6 (diff) | |
| download | linux-bb084c0f61d659f0e6d371b096e0e57998f191d6.tar.gz linux-bb084c0f61d659f0e6d371b096e0e57998f191d6.tar.bz2 linux-bb084c0f61d659f0e6d371b096e0e57998f191d6.zip | |
backlight: pwm_bl: Don't use GPIOF_* with gpiod_get_direction
The documentation was wrong, gpiod_get_direction() returns 0/1 instead
of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
("gpio: correct docs about return value of gpiod_get_direction"). Now,
fix this user (until a better, system-wide solution is in place).
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/backlight/pwm_bl.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 8e3f1245f5c5..44ac5bde4e9d 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -321,14 +321,14 @@ static int pwm_backlight_probe(struct platform_device *pdev) /* * If the GPIO is not known to be already configured as output, that - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL, - * change the direction to output and set the GPIO as active. + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the + * direction to output and set the GPIO as active. * Do not force the GPIO to active when it was already output as it * could cause backlight flickering or we would enable the backlight too * early. Leave the decision of the initial backlight state for later. */ if (pb->enable_gpio && - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT) + gpiod_get_direction(pb->enable_gpio) != 0) gpiod_direction_output(pb->enable_gpio, 1); pb->power_supply = devm_regulator_get(&pdev->dev, "power"); |