summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorErik Mouw <mouw@nl.linux.org>2008-02-04 18:56:54 +0100
committerJeff Garzik <jeff@garzik.org>2008-02-05 13:31:29 -0500
commit06f7525be463ef95bfdba001484bda04d00ec74e (patch)
tree5a7c8f5e07b029c9d7273301d5a8d4a76e9573bc /drivers
parent6c04a515085e6b94266db3e0e05c2700eeffa469 (diff)
downloadlinux-06f7525be463ef95bfdba001484bda04d00ec74e.tar.gz
linux-06f7525be463ef95bfdba001484bda04d00ec74e.tar.bz2
linux-06f7525be463ef95bfdba001484bda04d00ec74e.zip
xircom_cb should return NETDEV_TX_BUSY when no descriptors available
Changes in other networking paths uncovered a bug in the xircom_cb driver which made the kernel spew lots of the following error messages: BUG eth1 code -5 qlen 0 It turned out that the driver returned -EIO when there was no descriptor available for sending packets. It should return NETDEV_TX_BUSY instead. This was discussed on the netdev list before, see http://thread.gmane.org/gmane.linux.network/84603 . Signed-off-by: Erik Mouw <mouw@nl.linux.org> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/tulip/xircom_cb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/tulip/xircom_cb.c b/drivers/net/tulip/xircom_cb.c
index 8fc7274642eb..6b93d0169116 100644
--- a/drivers/net/tulip/xircom_cb.c
+++ b/drivers/net/tulip/xircom_cb.c
@@ -441,7 +441,7 @@ static int xircom_start_xmit(struct sk_buff *skb, struct net_device *dev)
spin_unlock_irqrestore(&card->lock,flags);
trigger_transmit(card);
- return -EIO;
+ return NETDEV_TX_BUSY;
}