diff options
| author | Wolfram Sang <wsa+renesas@sang-engineering.com> | 2015-03-23 09:26:39 +0100 |
|---|---|---|
| committer | Wolfram Sang <wsa@the-dreams.de> | 2015-03-27 16:53:40 +0100 |
| commit | 98e982b3a29829b676b723e42c1184c87e5242d0 (patch) | |
| tree | b65bd89a53eed65aecf4d95229cba99825e5ab5c /drivers | |
| parent | d0c892f59c918535f902caea63637af87d931d91 (diff) | |
| download | linux-98e982b3a29829b676b723e42c1184c87e5242d0.tar.gz linux-98e982b3a29829b676b723e42c1184c87e5242d0.tar.bz2 linux-98e982b3a29829b676b723e42c1184c87e5242d0.zip | |
i2c: slave-eeprom: add more info when to increase the pointer
It is a bit subtle when to correctly increase the buffer index when
reading. Make this clearer by adding some more comments and pointers to
the docs.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/i2c/i2c-slave-eeprom.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c index 3fb45d894d80..822374654609 100644 --- a/drivers/i2c/i2c-slave-eeprom.c +++ b/drivers/i2c/i2c-slave-eeprom.c @@ -48,12 +48,18 @@ static int i2c_slave_eeprom_slave_cb(struct i2c_client *client, break; case I2C_SLAVE_READ_PROCESSED: + /* The previous byte made it to the bus, get next one */ eeprom->buffer_idx++; /* fallthrough */ case I2C_SLAVE_READ_REQUESTED: spin_lock(&eeprom->buffer_lock); *val = eeprom->buffer[eeprom->buffer_idx]; spin_unlock(&eeprom->buffer_lock); + /* + * Do not increment buffer_idx here, because we don't know if + * this byte will be actually used. Read Linux I2C slave docs + * for details. + */ break; case I2C_SLAVE_STOP: |