diff options
| author | Somasundaram Krishnasamy <somasundaram.krishnasamy@oracle.com> | 2017-04-07 12:14:55 -0700 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2017-04-24 15:02:14 -0400 |
| commit | 117aceb030307dcd431fdcff87ce988d3016c34a (patch) | |
| tree | 6ee850484a06b5d14f63617a2a6126cd3f4cac11 /drivers | |
| parent | 948f581a53b704b984aa20df009f0a2b4cf7f907 (diff) | |
| download | linux-117aceb030307dcd431fdcff87ce988d3016c34a.tar.gz linux-117aceb030307dcd431fdcff87ce988d3016c34a.tar.bz2 linux-117aceb030307dcd431fdcff87ce988d3016c34a.zip | |
dm era: save spacemap metadata root after the pre-commit
When committing era metadata to disk, it doesn't always save the latest
spacemap metadata root in superblock. Due to this, metadata is getting
corrupted sometimes when reopening the device. The correct order of update
should be, pre-commit (shadows spacemap root), save the spacemap root
(newly shadowed block) to in-core superblock and then the final commit.
Cc: stable@vger.kernel.org
Signed-off-by: Somasundaram Krishnasamy <somasundaram.krishnasamy@oracle.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/md/dm-era-target.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/md/dm-era-target.c b/drivers/md/dm-era-target.c index 9fab33b113c4..68d4084377ad 100644 --- a/drivers/md/dm-era-target.c +++ b/drivers/md/dm-era-target.c @@ -961,15 +961,15 @@ static int metadata_commit(struct era_metadata *md) } } - r = save_sm_root(md); + r = dm_tm_pre_commit(md->tm); if (r) { - DMERR("%s: save_sm_root failed", __func__); + DMERR("%s: pre commit failed", __func__); return r; } - r = dm_tm_pre_commit(md->tm); + r = save_sm_root(md); if (r) { - DMERR("%s: pre commit failed", __func__); + DMERR("%s: save_sm_root failed", __func__); return r; } |