diff options
| author | Felipe Balbi <balbi@ti.com> | 2011-12-19 13:45:01 +0200 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2011-12-19 13:45:01 +0200 |
| commit | 7422ba5343b8c1dbe1a517d0fcc15e7d671ca960 (patch) | |
| tree | fb08da5707bb6498a42eef28e10200fd79356e68 /drivers | |
| parent | 248b122b131202de95aaa3670e48465619bdff14 (diff) | |
| download | linux-7422ba5343b8c1dbe1a517d0fcc15e7d671ca960.tar.gz linux-7422ba5343b8c1dbe1a517d0fcc15e7d671ca960.tar.bz2 linux-7422ba5343b8c1dbe1a517d0fcc15e7d671ca960.zip | |
usb: gadget: epautoconf: do not change number of streams
We should not change gadget driver's descriptors just
because we think it's right to do so.
There are several of reasons which would support this
statement but it suffices to say that this was probably
never tested because it updates bmAttributes without
asking the driver if it's ok to do so.
This means that e.g. on UASP gadget it would enable
stream support even for the command endpoint which must
not have stream support enabled.
In fact, this change is fixing the bug introduced by
commit a59d6b9 (usb: gadget: add streams support to
the gadget framework) which was caught when testing
UASP gadget with dwc3 driver.
Cc: Tatyana Brokhman <tlinder@codeaurora.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/gadget/epautoconf.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadget/epautoconf.c index 596a0b464e61..4dff83d2f265 100644 --- a/drivers/usb/gadget/epautoconf.c +++ b/drivers/usb/gadget/epautoconf.c @@ -130,9 +130,6 @@ ep_matches ( num_req_streams = ep_comp->bmAttributes & 0x1f; if (num_req_streams > ep->max_streams) return 0; - /* Update the ep_comp descriptor if needed */ - if (num_req_streams != ep->max_streams) - ep_comp->bmAttributes = ep->max_streams; } } |