summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorSean Anderson <sean.anderson@linux.dev>2024-06-28 16:55:39 -0400
committerVinod Koul <vkoul@kernel.org>2024-07-02 18:48:09 +0530
commitd79c6840917097285e03a49f709321f5fb972750 (patch)
treec5754dd0550cfbecc9e2c2941cd72f970957c74e /drivers
parent235d8b663ab9e6cc13f8374abfffa559f50b57b6 (diff)
downloadlinux-d79c6840917097285e03a49f709321f5fb972750.tar.gz
linux-d79c6840917097285e03a49f709321f5fb972750.tar.bz2
linux-d79c6840917097285e03a49f709321f5fb972750.zip
phy: zynqmp: Take the phy mutex in xlate
Take the phy mutex in xlate to protect against concurrent modification/access to gtr_phy. This does not typically cause any issues, since in most systems the phys are only xlated once and thereafter accessed with the phy API (which takes the locks). However, we are about to allow userspace to access phys for debugging, so it's important to avoid any data races. Signed-off-by: Sean Anderson <sean.anderson@linux.dev> Link: https://lore.kernel.org/r/20240628205540.3098010-5-sean.anderson@linux.dev Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/phy/xilinx/phy-zynqmp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
index 4d697e11d8eb..991be42eef3d 100644
--- a/drivers/phy/xilinx/phy-zynqmp.c
+++ b/drivers/phy/xilinx/phy-zynqmp.c
@@ -759,6 +759,7 @@ static struct phy *xpsgtr_xlate(struct device *dev,
phy_type = args->args[1];
phy_instance = args->args[2];
+ guard(mutex)(&gtr_phy->phy->mutex);
ret = xpsgtr_set_lane_type(gtr_phy, phy_type, phy_instance);
if (ret < 0) {
dev_err(gtr_dev->dev, "Invalid PHY type and/or instance\n");