diff options
| author | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-06-05 23:09:14 +0200 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-06-07 20:09:49 +0200 |
| commit | abfdff44bc38e9e2ef7929f633fb8462632299d4 (patch) | |
| tree | 0ac2c1257f51bc418edf8b28b3ca2efdd48ae98c /drivers | |
| parent | 1928906d126f647ff025a54df4ed88c05b2afba9 (diff) | |
| download | linux-abfdff44bc38e9e2ef7929f633fb8462632299d4.tar.gz linux-abfdff44bc38e9e2ef7929f633fb8462632299d4.tar.bz2 linux-abfdff44bc38e9e2ef7929f633fb8462632299d4.zip | |
rtc: ensure rtc_set_alarm fails when alarms are not supported
When using RTC_ALM_SET or RTC_WKALM_SET with rtc_wkalrm.enabled not set,
rtc_timer_enqueue() is not called and rtc_set_alarm() may succeed but the
subsequent RTC_AIE_ON ioctl will fail. RTC_ALM_READ would also fail in that
case.
Ensure rtc_set_alarm() fails when alarms are not supported to avoid letting
programs think the alarms are working for a particular RTC when they are
not.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/rtc/interface.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index 7cbdc9228dd5..6d4012dd6922 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -441,6 +441,11 @@ int rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) { int err; + if (!rtc->ops) + return -ENODEV; + else if (!rtc->ops->set_alarm) + return -EINVAL; + err = rtc_valid_tm(&alarm->time); if (err != 0) return err; |