diff options
| author | Pali Rohár <pali.rohar@gmail.com> | 2014-01-28 20:26:44 +0000 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-02-01 10:59:39 -0800 |
| commit | 1bda2ac071cdfad217856126859bc0dc88ee6f83 (patch) | |
| tree | f935d6bb989736011ccbf173e1322bd57c3afc4d /fs/afs/proc.c | |
| parent | 5a5e75f4714a592f31e57f248b8f5c866f278b8d (diff) | |
| download | linux-1bda2ac071cdfad217856126859bc0dc88ee6f83.tar.gz linux-1bda2ac071cdfad217856126859bc0dc88ee6f83.tar.bz2 linux-1bda2ac071cdfad217856126859bc0dc88ee6f83.zip | |
afs: proc cells and rootcell are writeable
Both proc files are writeable and used for configuring cells. But
there is missing correct mode flag for writeable files. Without
this patch both proc files are read only.
[ It turns out they aren't really read-only, since root can write to
them even if the write bit isn't set due to CAP_DAC_OVERRIDE ]
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/afs/proc.c')
| -rw-r--r-- | fs/afs/proc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/afs/proc.c b/fs/afs/proc.c index bddc5120ed40..24a905b076fd 100644 --- a/fs/afs/proc.c +++ b/fs/afs/proc.c @@ -130,8 +130,8 @@ int afs_proc_init(void) if (!proc_afs) goto error_dir; - if (!proc_create("cells", 0, proc_afs, &afs_proc_cells_fops) || - !proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops)) + if (!proc_create("cells", 0644, proc_afs, &afs_proc_cells_fops) || + !proc_create("rootcell", 0644, proc_afs, &afs_proc_rootcell_fops)) goto error_tree; _leave(" = 0"); |