diff options
| author | Christoph Hellwig <hch@lst.de> | 2009-04-28 18:00:26 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:06 -0400 |
| commit | 8c85e125124a473d6f3e9bb187b0b84207f81d91 (patch) | |
| tree | d883424a156c00c55193e46567efdffddb6ef6b9 /fs/bfs | |
| parent | 517bfae28353e996160518add4d00033d3886e61 (diff) | |
| download | linux-8c85e125124a473d6f3e9bb187b0b84207f81d91.tar.gz linux-8c85e125124a473d6f3e9bb187b0b84207f81d91.tar.bz2 linux-8c85e125124a473d6f3e9bb187b0b84207f81d91.zip | |
remove ->write_super call in generic_shutdown_super
We just did a full fs writeout using sync_filesystem before, and if
that's not enough for the filesystem it can perform it's own writeout
in ->put_super, which many filesystems already do.
Move a call to foofs_write_super into every foofs_put_super for now to
guarantee identical behaviour until it's cleaned up by the individual
filesystem maintainers.
Exceptions:
- affs already has identical copy & pasted code at the beginning of
affs_put_super so no need to do it twice.
- xfs does the right thing without it and I have changes pending for
the xfs tree touching this are so I don't really need conflicts
here..
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/bfs')
| -rw-r--r-- | fs/bfs/inode.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index cc4062d12ca2..4cf3d269e271 100644 --- a/fs/bfs/inode.c +++ b/fs/bfs/inode.c @@ -30,6 +30,7 @@ MODULE_LICENSE("GPL"); #define dprintf(x...) #endif +static void bfs_write_super(struct super_block *s); void dump_imap(const char *prefix, struct super_block *s); struct inode *bfs_iget(struct super_block *sb, unsigned long ino) @@ -216,6 +217,9 @@ static void bfs_put_super(struct super_block *s) if (!info) return; + if (s->s_dirt) + bfs_write_super(s); + brelse(info->si_sbh); mutex_destroy(&info->bfs_lock); kfree(info->si_imap); |