diff options
| author | David Sterba <dsterba@suse.com> | 2024-01-23 23:34:57 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-03-04 16:24:47 +0100 |
| commit | a67242907b41537907111ec689d3c44088c2f76b (patch) | |
| tree | e49344b3f9b9d9ac68f1fd362e7a716ae4467dfb /fs/btrfs/disk-io.c | |
| parent | 9dcb6ed9ce53d24e7b7fba7e02512787cd4dfa72 (diff) | |
| download | linux-a67242907b41537907111ec689d3c44088c2f76b.tar.gz linux-a67242907b41537907111ec689d3c44088c2f76b.tar.bz2 linux-a67242907b41537907111ec689d3c44088c2f76b.zip | |
btrfs: handle invalid root reference found in btrfs_init_root_free_objectid()
The btrfs_init_root_free_objectid() looks up a root by a key, allowing
to do an inexact search when key->offset is -1. It's never expected to
find such item, as it would break the allowed range of a root id.
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/disk-io.c')
| -rw-r--r-- | fs/btrfs/disk-io.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index d43b5d5df4b4..b056b7d0e526 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -4927,7 +4927,14 @@ int btrfs_init_root_free_objectid(struct btrfs_root *root) ret = btrfs_search_slot(NULL, root, &search_key, path, 0, 0); if (ret < 0) goto error; - BUG_ON(ret == 0); /* Corruption */ + if (ret == 0) { + /* + * Key with offset -1 found, there would have to exist a root + * with such id, but this is out of valid range. + */ + ret = -EUCLEAN; + goto error; + } if (path->slots[0] > 0) { slot = path->slots[0] - 1; l = path->nodes[0]; |