summaryrefslogtreecommitdiffstats
path: root/fs/btrfs
diff options
context:
space:
mode:
authorAnand Jain <Anand.Jain@oracle.com>2014-05-20 14:38:11 +0800
committerChris Mason <clm@fb.com>2014-06-09 17:20:54 -0700
commit402a0f475938f26b0c7b3175c8163b91a12a8a9a (patch)
tree7ef1a815e6e0ceb3cbb3b78f6371f818fbd02f55 /fs/btrfs
parent67a77eb147a36fdc346f1b9ff84649209d51f1da (diff)
downloadlinux-402a0f475938f26b0c7b3175c8163b91a12a8a9a.tar.gz
linux-402a0f475938f26b0c7b3175c8163b91a12a8a9a.tar.bz2
linux-402a0f475938f26b0c7b3175c8163b91a12a8a9a.zip
btrfs: usage error should not be logged into system log
I have an opinion that system logs /var/log/messages are valuable info to investigate the real system issues at the data center. People handling data center issues do spend a lot time and efforts analyzing messages files. Having usage error logged into /var/log/messages is something we should avoid. Signed-off-by: Anand Jain <Anand.Jain@oracle.com> Reviewed-by: David Sterba <dsterba@suse.cz> Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs')
-rw-r--r--fs/btrfs/sysfs.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index ba2a645dee07..c0dfda5644f2 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -374,11 +374,8 @@ static ssize_t btrfs_label_store(struct kobject *kobj,
struct btrfs_root *root = fs_info->fs_root;
int ret;
- if (len >= BTRFS_LABEL_SIZE) {
- pr_err("BTRFS: unable to set label with more than %d bytes\n",
- BTRFS_LABEL_SIZE - 1);
+ if (len >= BTRFS_LABEL_SIZE)
return -EINVAL;
- }
trans = btrfs_start_transaction(root, 0);
if (IS_ERR(trans))