diff options
| author | Naohiro Aota <naohiro.aota@wdc.com> | 2022-05-03 17:48:54 -0700 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2022-05-16 17:17:32 +0200 |
| commit | 74e91b12b11560f01d120751d99d91d54b265d3d (patch) | |
| tree | 5cb3fb1c215e45941ec774285385809a73b1260d /fs/btrfs | |
| parent | 56fbb0a4e8b3e929e41cc846e6ef89eb01152201 (diff) | |
| download | linux-74e91b12b11560f01d120751d99d91d54b265d3d.tar.gz linux-74e91b12b11560f01d120751d99d91d54b265d3d.tar.bz2 linux-74e91b12b11560f01d120751d99d91d54b265d3d.zip | |
btrfs: zoned: zone finish unused block group
While the active zones within an active block group are reset, and their
active resource is released, the block group itself is kept in the active
block group list and marked as active. As a result, the list will contain
more than max_active_zones block groups. That itself is not fatal for the
device as the zones are properly reset.
However, that inflated list is, of course, strange. Also, a to-appear
patch series, which deactivates an active block group on demand, gets
confused with the wrong list.
So, fix the issue by finishing the unused block group once it gets
read-only, so that we can release the active resource in an early stage.
Fixes: be1a1d7a5d24 ("btrfs: zoned: finish fully written block group")
CC: stable@vger.kernel.org # 5.16+
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/block-group.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c index 9739f3e8230a..ede389f2602d 100644 --- a/fs/btrfs/block-group.c +++ b/fs/btrfs/block-group.c @@ -1385,6 +1385,14 @@ void btrfs_delete_unused_bgs(struct btrfs_fs_info *fs_info) goto next; } + ret = btrfs_zone_finish(block_group); + if (ret < 0) { + btrfs_dec_block_group_ro(block_group); + if (ret == -EAGAIN) + ret = 0; + goto next; + } + /* * Want to do this before we do anything else so we can recover * properly if we fail to join the transaction. |