diff options
| author | Yan, Zheng <zyan@redhat.com> | 2020-03-05 20:21:04 +0800 |
|---|---|---|
| committer | Ilya Dryomov <idryomov@gmail.com> | 2020-03-30 12:42:42 +0200 |
| commit | bf73c62e7ff8dc220f3f57df4e42f9947320c447 (patch) | |
| tree | 51f79339f70165d99272ae502419a464ad2850c7 /fs/ceph | |
| parent | 11ba6b9ceeb4e20e0610ad249f9187dba412f787 (diff) | |
| download | linux-bf73c62e7ff8dc220f3f57df4e42f9947320c447.tar.gz linux-bf73c62e7ff8dc220f3f57df4e42f9947320c447.tar.bz2 linux-bf73c62e7ff8dc220f3f57df4e42f9947320c447.zip | |
ceph: check all mds' caps after page writeback
If an inode has caps from multiple mds's, the following can happen:
- non-auth mds revokes Fsc. Fcb is used, so page writeback is queued.
- when writeback finishes, ceph_check_caps() is called with auth only
flag. ceph_check_caps() invalidates pagecache, but skips checking any
non-auth caps.
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'fs/ceph')
| -rw-r--r-- | fs/ceph/caps.c | 2 | ||||
| -rw-r--r-- | fs/ceph/inode.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c index 0b3a36310033..342a32c74c64 100644 --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -3062,7 +3062,7 @@ void ceph_put_wrbuffer_cap_refs(struct ceph_inode_info *ci, int nr, spin_unlock(&ci->i_ceph_lock); if (last) { - ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL); + ceph_check_caps(ci, 0, NULL); } else if (flush_snaps) { ceph_flush_snaps(ci, NULL); } diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index c7ff9f7067f6..ee40ba7e0e77 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -1984,7 +1984,7 @@ retry: mutex_unlock(&ci->i_truncate_mutex); if (wrbuffer_refs == 0) - ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL); + ceph_check_caps(ci, 0, NULL); wake_up_all(&ci->i_cap_wq); } |