diff options
| author | Andrea Parri <andrea.parri@amarulasolutions.com> | 2019-05-20 19:23:58 +0200 |
|---|---|---|
| committer | Ilya Dryomov <idryomov@gmail.com> | 2019-07-08 14:01:42 +0200 |
| commit | 749607731e26dfb2558118038c40e9c0c80d23b5 (patch) | |
| tree | fb689b0cecc98404c029b3f626bf7d5929b16f8d /fs/ceph | |
| parent | 718807289d4130be1fe13f24f018733116958070 (diff) | |
| download | linux-749607731e26dfb2558118038c40e9c0c80d23b5.tar.gz linux-749607731e26dfb2558118038c40e9c0c80d23b5.tar.bz2 linux-749607731e26dfb2558118038c40e9c0c80d23b5.zip | |
ceph: fix improper use of smp_mb__before_atomic()
This barrier only applies to the read-modify-write operations; in
particular, it does not apply to the atomic64_set() primitive.
Replace the barrier with an smp_mb().
Fixes: fdd4e15838e59 ("ceph: rework dcache readdir")
Reported-by: "Paul E. McKenney" <paulmck@linux.ibm.com>
Reported-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'fs/ceph')
| -rw-r--r-- | fs/ceph/super.h | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/fs/ceph/super.h b/fs/ceph/super.h index 7209548527ab..29ea4eba98fe 100644 --- a/fs/ceph/super.h +++ b/fs/ceph/super.h @@ -545,7 +545,12 @@ static inline void __ceph_dir_set_complete(struct ceph_inode_info *ci, long long release_count, long long ordered_count) { - smp_mb__before_atomic(); + /* + * Makes sure operations that setup readdir cache (update page + * cache and i_size) are strongly ordered w.r.t. the following + * atomic64_set() operations. + */ + smp_mb(); atomic64_set(&ci->i_complete_seq[0], release_count); atomic64_set(&ci->i_complete_seq[1], ordered_count); } |