diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2013-01-30 19:21:14 -0800 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2013-02-13 06:00:53 -0800 |
commit | d83f5901bc0cd7131a3b8534169ee889efc4c257 (patch) | |
tree | ec47947fcec33d9d373367d86b787b08be997168 /fs/coda/psdev.c | |
parent | 9fd973e085f7759f710603422b2e11ad5f2e000d (diff) | |
download | linux-d83f5901bc0cd7131a3b8534169ee889efc4c257.tar.gz linux-d83f5901bc0cd7131a3b8534169ee889efc4c257.tar.bz2 linux-d83f5901bc0cd7131a3b8534169ee889efc4c257.zip |
coda: Restrict coda messages to the initial user namespace
Remove the slight chance that uids and gids in coda messages will be
interpreted in the wrong user namespace.
- Only allow processes in the initial user namespace to open the coda
character device to communicate with coda filesystems.
- Explicitly convert the uids in the coda header into the initial user
namespace.
- In coda_vattr_to_attr make kuids and kgids from the initial user
namespace uids and gids in struct coda_vattr that just came from
userspace.
- In coda_iattr_to_vattr convert kuids and kgids into uids and gids
in the intial user namespace and store them in struct coda_vattr for
sending to coda userspace programs.
Nothing needs to be changed with mounts as coda does not support
being mounted in anything other than the initial user namespace.
Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'fs/coda/psdev.c')
-rw-r--r-- | fs/coda/psdev.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c index dd60f905d4fe..ebc2bae6c289 100644 --- a/fs/coda/psdev.c +++ b/fs/coda/psdev.c @@ -270,6 +270,9 @@ static int coda_psdev_open(struct inode * inode, struct file * file) if (task_active_pid_ns(current) != &init_pid_ns) return -EINVAL; + if (current_user_ns() != &init_user_ns) + return -EINVAL; + idx = iminor(inode); if (idx < 0 || idx >= MAX_CODADEVS) return -ENODEV; |