diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2022-06-29 15:06:59 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2022-07-16 09:19:15 -0400 |
| commit | 4e3299eaddffd9d7d5b8bae28ad700bb775f02d0 (patch) | |
| tree | e9788bc97a081aa7e6a32cb8a1e525c6667cad1c /fs/coredump.c | |
| parent | e7478158e1378325907edfdd960eca98a1be405b (diff) | |
| download | linux-4e3299eaddffd9d7d5b8bae28ad700bb775f02d0.tar.gz linux-4e3299eaddffd9d7d5b8bae28ad700bb775f02d0.tar.bz2 linux-4e3299eaddffd9d7d5b8bae28ad700bb775f02d0.zip | |
fs: do not compare against ->llseek
Now vfs_llseek() can simply check for FMODE_LSEEK; if it's set,
we know that ->llseek() won't be NULL and if it's not we should
just fail with -ESPIPE.
A couple of other places where we used to check for special
values of ->llseek() (somewhat inconsistently) switched to
checking FMODE_LSEEK.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/coredump.c')
| -rw-r--r-- | fs/coredump.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/coredump.c b/fs/coredump.c index ebc43f960b64..9f4aae202109 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -816,9 +816,9 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr) { static char zeroes[PAGE_SIZE]; struct file *file = cprm->file; - if (file->f_op->llseek && file->f_op->llseek != no_llseek) { + if (file->f_mode & FMODE_LSEEK) { if (dump_interrupted() || - file->f_op->llseek(file, nr, SEEK_CUR) < 0) + vfs_llseek(file, nr, SEEK_CUR) < 0) return 0; cprm->pos += nr; return 1; |