diff options
| author | David Teigland <teigland@redhat.com> | 2006-12-13 10:39:20 -0600 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2007-02-05 13:35:59 -0500 |
| commit | 8d07fd509e9c82a59e37b8b18a2fd0e8ef8fc837 (patch) | |
| tree | 165b88e0208e00301a5069507e84df597d636de8 /fs/dlm/lock.c | |
| parent | da49f36f4f64feb281d7663be99e779b2aecc607 (diff) | |
| download | linux-8d07fd509e9c82a59e37b8b18a2fd0e8ef8fc837.tar.gz linux-8d07fd509e9c82a59e37b8b18a2fd0e8ef8fc837.tar.bz2 linux-8d07fd509e9c82a59e37b8b18a2fd0e8ef8fc837.zip | |
[DLM] fix receive_request() lvb copying
LVB's are not sent as part of new requests, but the code receiving the
request was copying data into the lvb anyway. The space in the message
where it mistakenly thought the lvb lived actually contained the resource
name, so it wound up incorrectly copying this name data into the lvb. Fix
is to just create the lvb, not copy junk into it.
Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/dlm/lock.c')
| -rw-r--r-- | fs/dlm/lock.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index cdf2cb9297fd..d8e919bad41a 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -2430,8 +2430,12 @@ static int receive_request_args(struct dlm_ls *ls, struct dlm_lkb *lkb, DLM_ASSERT(is_master_copy(lkb), dlm_print_lkb(lkb);); - if (receive_lvb(ls, lkb, ms)) - return -ENOMEM; + if (lkb->lkb_exflags & DLM_LKF_VALBLK) { + /* lkb was just created so there won't be an lvb yet */ + lkb->lkb_lvbptr = allocate_lvb(ls); + if (!lkb->lkb_lvbptr) + return -ENOMEM; + } return 0; } |