summaryrefslogtreecommitdiffstats
path: root/fs/dlm
diff options
context:
space:
mode:
authorWen Yang <wen.yang99@zte.com.cn>2018-11-28 15:25:00 +0800
committerDavid Teigland <teigland@redhat.com>2018-11-28 08:45:55 -0600
commitf31a89692830061bceba8469607e4e4b0f900159 (patch)
tree8af9d428a017b59e001b8faecfcb3f868989c3cc /fs/dlm
parent8fc6ed9a3508a0435b9270c313600799d210d319 (diff)
downloadlinux-f31a89692830061bceba8469607e4e4b0f900159.tar.gz
linux-f31a89692830061bceba8469607e4e4b0f900159.tar.bz2
linux-f31a89692830061bceba8469607e4e4b0f900159.zip
dlm: NULL check before kmem_cache_destroy is not needed
kmem_cache_destroy(NULL) is safe, so removes NULL check before freeing the mem. This patch also fix ifnullfree.cocci warnings. Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> Signed-off-by: David Teigland <teigland@redhat.com>
Diffstat (limited to 'fs/dlm')
-rw-r--r--fs/dlm/memory.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/fs/dlm/memory.c b/fs/dlm/memory.c
index 7cd24bccd4fe..37be29f21d04 100644
--- a/fs/dlm/memory.c
+++ b/fs/dlm/memory.c
@@ -38,10 +38,8 @@ int __init dlm_memory_init(void)
void dlm_memory_exit(void)
{
- if (lkb_cache)
- kmem_cache_destroy(lkb_cache);
- if (rsb_cache)
- kmem_cache_destroy(rsb_cache);
+ kmem_cache_destroy(lkb_cache);
+ kmem_cache_destroy(rsb_cache);
}
char *dlm_allocate_lvb(struct dlm_ls *ls)
@@ -86,8 +84,7 @@ void dlm_free_lkb(struct dlm_lkb *lkb)
struct dlm_user_args *ua;
ua = lkb->lkb_ua;
if (ua) {
- if (ua->lksb.sb_lvbptr)
- kfree(ua->lksb.sb_lvbptr);
+ kfree(ua->lksb.sb_lvbptr);
kfree(ua);
}
}